chore: scaffold project template with tooling and CI #3
+7,222
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikhfj
added
type: chore
5 tasks
robertky
force-pushed
the
chore/1-project-template
branch
from
f2769fa to
f2c7439
Compare
Set up the starting template for the group: - Vite + React + TypeScript, TanStack Query wired in main.tsx - ESLint 9 flat config (typescript-eslint, react-hooks, react-refresh, jsx-a11y, eslint-config-prettier) and Prettier - Vitest + React Testing Library + jsdom with placeholder App tests - GitHub Actions CI: format, lint, test, build on every PR - AGENTS.md with contributor and AI-agent conventions - README with project, scripts, workflow, and label documentation
GitHub Projects is disabled on git.ntnu.no, so the roadmap lives in the repo: milestone due dates, current status, workflow, and delivery checklist. Linked from README.
robertky
force-pushed
the
chore/1-project-template
branch
from
f2c7439 to
3d39e85
Compare
robertky
removed
the
ai-assisted
The NTNU GHES instance has no shared runners, so CI runs on a self-hosted runner on the group VM (#6): runs-on [self-hosted, linux, x64], setup guide in docs/ci-runner.md.
- vite base '/project1' so the build serves from the course-required path - docs/deployment.md: Apache setup, deploy flows, pitfalls, final URL - docs/ci-runner.md: VM hostname and network/VPN note - ROADMAP links the deployment guide
Pipeline: format/lint/test/build on every PR; pushes to main additionally rsync the built dist/ to /var/www/html/project1 on the group VM runner (sudoers entry grants NOPASSWD rsync to the runner user, see docs/ci-runner.md).
This was referenced Sep 4, 2026
rachelks
reviewed
Sep 5, 2026
There was a problem hiding this comment.
Looks good from my side, format/lint/test/build all pass locally! I only noticed two small things in the README:
- The conventional commit example uses #11 for a favorites feature, but #11 is now the BookCard issue. Maybe use a generic example or the correct issue number?
- The README says that all OpenLibrary API requests are mocked with MSW, but as far as I can tell, MSW is currently installed but the handlers/server setup is not part of this PR yet. Maybe phrase this as planned behavior until the API test setup is in place?
|
Thanks for the review, Rachel! Both points fixed in
Re-requesting your review since the push (approval is dismissed on new commits per repo rules). The two remaining external blockers are unchanged: repo admin for the runner (Trond's grant hasn't propagated yet — team still shows |
rachelks
approved these changes
Sep 5, 2026
This was referenced Sep 5, 2026
erikhfj
added a commit
that referenced
this pull request
Sep 5, 2026
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Initial project scaffold for Project 1:
Follow-up work
This PR intentionally provides the baseline only. The remaining setup work is tracked separately:
The CI decision remains tracked in #2. Self-hosted runner setup is tracked in #6 while the group checks available server access.
Validation
npm run format:checknpm run lintnpm testnpm run buildChecklist